Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add contao/core-bundle and contao/installation-bundle #464

Merged
4 commits merged into from
Aug 31, 2018
Merged

Add contao/core-bundle and contao/installation-bundle #464

4 commits merged into from
Aug 31, 2018

Conversation

leofeyer
Copy link
Contributor

@leofeyer leofeyer commented Aug 30, 2018 •
edited
Loading

Q A
License MIT

This PR replaces #426.

ghost
ghost suggested changes Aug 30, 2018
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

ghost
ghost suggested changes Aug 30, 2018
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

ghost
ghost suggested changes Aug 30, 2018
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

ghost
ghost approved these changes Aug 30, 2018
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@leofeyer leofeyer changed the title [WIP] Add a recipe for contao/core-bundle and contao/installation-bundle Add contao/core-bundle and contao/installation-bundle Aug 30, 2018
ghost
ghost approved these changes Aug 30, 2018
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@leofeyer
Copy link
Contributor Author

The tests are failing, because contao/core-bundle requires friendsofsymfony/http-cache, which requires php-http/client-implementation. It is up to the end user to select a client implementation, therefore the packages only have a dev requirement for a concrete implementation, which however is not loaded by composer require. 😢

@leofeyer
Copy link
Contributor Author

@Nyholm Any idea how we could fix this?

ghost
ghost approved these changes Aug 30, 2018
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

ghost
ghost approved these changes Aug 30, 2018
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

ghost
ghost suggested changes Aug 30, 2018
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

ghost
ghost suggested changes Aug 30, 2018
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

@fabpot fabpot mentioned this pull request Aug 31, 2018
Closed
fabpot
fabpot reviewed Aug 31, 2018
View reviewed changes
Copy link
Member

@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge now

@ghost ghost merged commit b91c7d5 into symfony:master Aug 31, 2018
ghost pushed a commit that referenced this pull request Aug 31, 2018
Merge pull request #464
33bfc04
@leofeyer leofeyer deleted the contao branch August 31, 2018 12:34
@Tetragramat Tetragramat mentioned this pull request Mar 10, 2020
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@maxhelias maxhelias maxhelias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leofeyer @fabpot @maxhelias