Fix inconsistent return points.

symfony · Aug 20, 2019 · 5179b12 · 5179b12
1 parent 60838d6
commit 5179b12
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/Pipes/AbstractPipes.php b/Pipes/AbstractPipes.php
@@ -88,12 +88,14 @@ protected function unblock()
     /**
      * Writes input to stdin.
      *
+     * @return array|null
+     *
      * @throws InvalidArgumentException When an input iterator yields a non supported value
      */
     protected function write()
     {
         if (!isset($this->pipes[0])) {
-            return;
+            return null;
         }
         $input = $this->input;
 
@@ -122,7 +124,7 @@ protected function write()
 
         // let's have a look if something changed in streams
         if (false === @stream_select($r, $w, $e, 0, 0)) {
-            return;
+            return null;
         }
 
         foreach ($w as $stdin) {
@@ -166,6 +168,8 @@ protected function write()
         } elseif (!$w) {
             return [$this->pipes[0]];
         }
+
+        return null;
     }
 
     /**

diff --git a/Tests/ProcessTest.php b/Tests/ProcessTest.php
@@ -1231,6 +1231,8 @@ public function testInputStreamWithCallable()
 
                 return $stream;
             }
+
+            return null;
         };
 
         $input = new InputStream();