Resolve "level" env var at runtime #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
commented
Nov 26, 2022
GromNaN
commented
Nov 26, 2022
GromNaN
changed the title
GromNaN
commented
Nov 28, 2022
|
Did you check if this is even needed? Last time I checked, every monolog handler already casts the log level. I see no reason for this bundle to cast the level at all. |
|
Why didn't I think of that! You are absolutely right. By default the I'll check for older versions and update the PR. |
|
|
GromNaN
force-pushed
the
level-factory-enum
branch
3 times, most recently
from
b6e7432 to
6204234
Compare
lyrixx
reviewed
Dec 3, 2022
Seldaek
approved these changes
Dec 4, 2022
GromNaN
force-pushed
the
level-factory-enum
branch
from
6204234 to
db45663
Compare
|
@GromNaN do you have an idea on when this will be released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #413, #444
Currently, the log level is read when the container built. This means we cannot change a log level at runtime using env vars.
With this change, log level can be modified for a specific command run:
LOG_LEVEL=debug bin/console ...I would like to get some feedbacks before updating tests. I don't know yet what is the best strategy to check the resolution of the values.