Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[make:crud] Improve controller generation #939

Merged
merged 2 commits into from
Feb 23, 2022
Merged

[make:crud] Improve controller generation #939

merged 2 commits into from
Feb 23, 2022

Conversation

bdaler
Copy link
Contributor

@bdaler bdaler commented Aug 9, 2021

#788

  • Add new methods add and remove to repository template.
  • Improve controller template to generate methods new, edit and delete.
  • Fix test repository fixtures files according new methods.

@fd6130 fd6130 mentioned this pull request Aug 28, 2021
Closed
bdaler and others added 2 commits February 23, 2022 15:20
@jrushlow
- Add new methods add and remove to repository template.
a9b817d 
- Improve controller template to generate methods `new`, `edit` and `delete`.
- Fix test repository fixtures files according new methods.
@jrushlow
fix missing entity manager
a6bcf69
@jrushlow jrushlow force-pushed the improveCrudControllerGeneration.788 branch from ddd3f74 to a6bcf69 Compare February 23, 2022 20:21
@jrushlow jrushlow added the Status: Reviewed Has been reviewed by a maintainer label Feb 23, 2022
jrushlow
jrushlow approved these changes Feb 23, 2022
View reviewed changes
Copy link
Collaborator

@jrushlow jrushlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bdaler for the contribution!

@jrushlow jrushlow merged commit 1f20a8c into symfony:main Feb 23, 2022
@jrushlow jrushlow mentioned this pull request Feb 23, 2022
Merged
@MrYamous MrYamous mentioned this pull request Jun 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrushlow jrushlow jrushlow approved these changes

Assignees
No one assigned
Labels
Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdaler @jrushlow