Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fixes test error about missing annotation_reader #915

Merged
merged 1 commit into from
Jun 30, 2021

Conversation

weaverryan
Copy link
Member

Hi!

Starting in Composer 2.1 & Symfony 5.3, whether the annotations system is auto-enabled depends on whether doctrine/annotations will be available without taking into account dev dependencies. In MakerBundle, when we boot a test container, doctrine/annotations is a dev dependency only (appropriately), which incorrectly hints to the container
that the system should not be initialized. So, we force it.

Cheers!

Starting in Composer 2.1 & Symfony 5.3, whether the annotations system is auto-enabled
depends on whether doctrine/annotations will be available *without* taking into account
dev dependencies. In MakerBundle, when we boot a test container, doctrine/annotations
is a dev dependency only (appropriately), which incorrectly hints to the container
that the system should not be initialized. So, we force it.
@weaverryan weaverryan force-pushed the fix-annotations-test-error branch from ce0847c to e01259e Compare June 30, 2021 13:44
Copy link
Collaborator

@jrushlow jrushlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome find!

@weaverryan weaverryan merged commit 6e951c6 into symfony:main Jun 30, 2021
@jrushlow jrushlow mentioned this pull request Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants