-
-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ysm] handle linebreak followed by an immediate root-level comment #1476
Merged
+22
−3
Merged
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
c063696
WIP - [ysm] failed test
jrushlow a21bca6
add expectation - without worrying about placement
jrushlow 247b72e
remove clutter
jrushlow 5f1aff6
minimal viable test
jrushlow 7e8a607
speed up CI tests
jrushlow 3e6176a
return types
jrushlow 470c5d6
only a wip test
jrushlow e7fd956
remove more clutter
jrushlow eb77ae7
unable to handle root level comment after key
jrushlow bd07227
found the problem
jrushlow 8adda1c
Revert "speed up CI tests"
jrushlow 570be4d
fix file name
jrushlow File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
security: | ||
firewalls: | ||
# main: | ||
=== | ||
$data['security'] = [ | ||
'firewalls' => 'a firewall', | ||
'providers' => 'a provider' | ||
]; | ||
=== | ||
security: | ||
firewalls: 'a firewall' | ||
providers: 'a provider' | ||
# main: |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ysm has the wrong indentation i think for
providers
- it looks like its trying to set it at0
when it should be2
?