Add 'attribute' to allowed mapping config types #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! We love contributions. However, this repository is what we call a "subtree split": a read-only copy of one directory of the main Symfony repository. It is used by Composer to allow developers to depend on specific Symfony components. If you want to contribute, you should instead open a pull request on the main repository: https://github.com/symfony/symfony Thank you for your contribution! PS: if you haven't already, please add tests, and beware that bug fixes should be submitted on the lowest maintained branch where they apply. |
dunglas
suggested changes
Mar 25, 2021
Update exception message with allowed values Co-authored-by: Kévin Dunglas <[email protected]>
thx! missed it |
dunglas
approved these changes
Mar 26, 2021
|
Closing, as explained by the bot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Recently doctrine/orm#8266 was merged in. I had made a new symfony project and wanted to use the entity attributes to generate a schema, I was able to do so but needed to allow setting a type of "attribute" in my doctrine orm mappings type configuration by changing this class
(and adding the corresponding parameter for the attributes driver to DoctrineBundle (doctrine/DoctrineBundle#1313)
I am not sure if this is useful, sorry if it is not! (I am not sure which branch this should go to, because I guess this relies on doctrine/orm 2.9.x)
thanks for all the code by the way!