[explorer] fix: search namespace without dash #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for explorer-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
AnthonyLaw
force-pushed
the
task/search-namespace-without-dash
branch
from
814a0a4
to
686b29a
Compare
AnthonyLaw
requested review from
cryptoBeliever,
gimre-xymcity and
Jaguar0625
Jaguar0625
reviewed
Nov 23, 2022
cryptoBeliever
previously approved these changes
Nov 23, 2022
Jaguar0625
reviewed
Dec 22, 2022
AnthonyLaw
force-pushed
the
task/search-namespace-without-dash
branch
2 times, most recently
from
02a0a7a
to
a102bfc
Compare
Jaguar0625
reviewed
Dec 22, 2022
|
|
||
| inputValues.forEach(({input, pageName}) => runBasicWhitespaceTests(pageName, input, { | ||
| pageName, | ||
| param: input.replace(/\s/g, '') |
There was a problem hiding this comment.
consider adding expected to last object and then
param: expected ? expected : input
There was a problem hiding this comment.
consider adding expected to last object and then
I am confused about this.
the object below is considered as expectedResult
{
pageName,
param: input.replace(/\s/g, '')
}param: expected ? expected : input
why do we need this?
Jaguar0625
approved these changes
Dec 22, 2022
AnthonyLaw
force-pushed
the
task/search-namespace-without-dash
branch
from
a102bfc
to
6b6cb4b
Compare
AnthonyLaw
added a commit
that referenced
this pull request
May 16, 2023
* [explorer] fix: search namespace without dash * [explorer] task: refactor UI store unit test * [explorer] task: patch update on UI store
AnthonyLaw
added a commit
that referenced
this pull request
May 16, 2023
* [explorer] fix: search namespace without dash * [explorer] task: refactor UI store unit test * [explorer] task: patch update on UI store
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the issue?
-, it not working in explorer, the reason is that the search box is defaulted removed-.-to prevent the address with a dash.What's the fix?
-in the search box because the namespace allows the string contain a dash.-in our address format (for example wallet), so it won't affect address search.