Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the exported data to the CSV file #450

Closed
wants to merge 1 commit into from

Conversation

David0817
Copy link
Contributor

fix #416

Copy link
Contributor

@fullcircle23 fullcircle23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start. CSV download works.

But data in CSV download is not well formatted:

type networkType version deadline maxFee signature signer transactionInfo innerTransactions cosignatures recipientAddress mosaics message
16724 152 1 {"value":"2020-06-08T12:46:44.119"} {"lower":1000000,"higher":0} 2AC26975709C8072650BFBF4F21A483EB22B38E1957F4AAD92FF83638733C8390A48C89C85F7A5CB3B7F5021721E85D632AD84C6B66DD37CB9FA3E9EF53B1403 {"publicKey":"9544226AD1FCD53570E5314B3BB1CB8A555ACA0054BCAFBA46F75719874AE249","address":{"address":"TA6W432Q3NHNQ5HQSKQ52XL7MFJZQITJRYBILQGG","networkType":152}} {"height":{"lower":84689,"higher":0},"index":0,"id":"5EDDC197A7DED64D90A473C6","hash":"F9185D0F512E42A250B3451847B310A0FE5D5135B925C685F7E7F32F84CEF572","merkleComponentHash":"F9185D0F512E42A250B3451847B310A0FE5D5135B925C685F7E7F32F84CEF572"}     {"address":"TBOVIHJQKMX4LB7KF5AAD6TMNSTMVSNW5JUXM6QH","networkType":152} [{"id":{"id":{"lower":3821645258,"higher":97953805}},"amount":{"lower":3205032704,"higher":1}}] {"type":0,"payload":""}

The fields, field names and data should be similar to what user sees in transaction details. The data should be in plain text, not JSON format.

For example:
Type should be Transfer not 16724.
Network Type should be TEST_NET not 152.
Amount should be the actual amount like 7500, not like {"lower":3205032704,"higher":1}.
Similarly for MosaicId, NamespaceId, and other numeric values must be as a single value, not in lower and higher format.

@David0817 @evias

@fullcircle23
Copy link
Contributor

Also, the style, microcopy, and position of the Download button need to be revisited separately. This applies to the Harvesting Show wizard button and potentially other components as well to achieve a clean, consistent and aesthetically pleasing design.

@evias evias self-assigned this Jul 15, 2020
@dgarcia360 dgarcia360 changed the base branch from master to main July 22, 2020 11:16
@evias evias closed this Sep 15, 2020
@evias evias deleted the export_trasaction_info branch September 15, 2020 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

csv-export for the desktop-wallet
3 participants