Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wallet/desktop] feat: add multisig toggle to allow/disallow signing multisig transactions from unknown accounts #1889

Merged
merged 12 commits into from
Aug 16, 2022

Conversation

OlegMakarenko
Copy link
Contributor

Problem

The current set of measures is insufficient to protect users from multi-signature scam transactions.

Current behaviour

Wallet presents a cosignature form explaining the risks of signing multi-signature transactions from unknown accounts.

Solution

  • Disallow signing multisig transactions from unknown accounts by default.
  • Present warning instead.
  • Added the advanced settings section with "toggle" (dropdown) which can turn on/off this security protection.

image
image

@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2022

Codecov Report

Merging #1889 (dfd8edf) into dev (8334bb5) will increase coverage by 1.18%.
The diff coverage is 99.20%.

❗ Current head dfd8edf differs from pull request most recent head 3751594. Consider uploading reports for the commit 3751594 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1889      +/-   ##
==========================================
+ Coverage   25.58%   26.77%   +1.18%     
==========================================
  Files         591      593       +2     
  Lines       14022    14111      +89     
  Branches     2372     2381       +9     
==========================================
+ Hits         3588     3778     +190     
+ Misses      10349    10249     -100     
+ Partials       85       84       -1     
Flag Coverage Δ
wallet-desktop 26.77% <99.20%> (+1.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ents/AccountMultisigGraph/AccountMultisigGraph.vue 100.00% <ø> (ø)
src/store/AppInfo.ts 16.43% <0.00%> (-0.23%) ⬇️
.../forms/FormGeneralSettings/FormGeneralSettings.vue 100.00% <ø> (ø)
src/views/modals/ModalSettings/ModalSettings.vue 100.00% <ø> (ø)
...sactionCosignature/ModalTransactionCosignature.vue 100.00% <ø> (ø)
...accounts/AccountDetailsPage/AccountDetailsPage.vue 100.00% <ø> (+100.00%) ⬆️
...nts/AccountMultisigGraph/AccountMultisigGraphTs.ts 100.00% <100.00%> (ø)
src/core/database/entities/SettingsModel.ts 100.00% <100.00%> (ø)
src/services/SettingService.ts 73.07% <100.00%> (ø)
src/store/Account.ts 11.11% <100.00%> (+5.83%) ⬆️
... and 13 more

@cryptoBeliever cryptoBeliever self-requested a review August 12, 2022 10:52
cryptoBeliever
cryptoBeliever previously approved these changes Aug 12, 2022
@OlegMakarenko OlegMakarenko marked this pull request as ready for review August 12, 2022 11:27
@OlegMakarenko OlegMakarenko merged commit ecde59f into dev Aug 16, 2022
@OlegMakarenko OlegMakarenko deleted the feat/add-multisig-toggle branch August 16, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toggle to allow/disallow signing multisig transactions from unknown accounts
4 participants