-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wallet/desktop] feat: add multisig toggle to allow/disallow signing multisig transactions from unknown accounts #1889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #1889 +/- ##
==========================================
+ Coverage 25.58% 26.77% +1.18%
==========================================
Files 591 593 +2
Lines 14022 14111 +89
Branches 2372 2381 +9
==========================================
+ Hits 3588 3778 +190
+ Misses 10349 10249 -100
+ Partials 85 84 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
cryptoBeliever
previously approved these changes
Aug 12, 2022
Jaguar0625
reviewed
Aug 15, 2022
Jaguar0625
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current set of measures is insufficient to protect users from multi-signature scam transactions.
Current behaviour
Wallet presents a cosignature form explaining the risks of signing multi-signature transactions from unknown accounts.
Solution