[wallet/desktop] fix: cosign form is not presented for multisig tx iss#1863 #1881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f tx needs cosignature
Jaguar0625
reviewed
Jul 26, 2022
src/views/modals/ModalTransactionCosignature/ModalTransactionCosignatureTs.ts
Outdated
Show resolved
Hide resolved
OlegMakarenko
changed the title
OlegMakarenko
changed the title
Codecov Report
@@ Coverage Diff @@
## dev #1881 +/- ##
==========================================
+ Coverage 25.58% 26.20% +0.62%
==========================================
Files 591 591
Lines 14022 14068 +46
Branches 2372 2377 +5
==========================================
+ Hits 3588 3687 +99
+ Misses 10349 10297 -52
+ Partials 85 84 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Jaguar0625
reviewed
Aug 1, 2022
Jaguar0625
approved these changes
Aug 1, 2022
OlegMakarenko
added a commit
that referenced
this pull request
Aug 3, 2022
…s#1863 (#1881) * [wallet/desktop] fix: cosign form is not presented for multisig tx fix multisig graph action * [wallet/desktop] task: update AccountMultisigGraph test * [wallet/desktop] task: use root and current multisig graph to check if tx needs cosignature * [wallet/desktop] feat: add new multisig graph presentation, fix graph construction * [wallet/desktop] task: update and add tests for AccountMultisigGraph component * [wallet/desktop] task: show multisig graph for cosigners * [wallet/desktop] task: sort multisig graph by address, remove old tree * [wallet/desktop] task: add test for AccountDetailsPage * [wallet/desktop] fix: AccountDetailsPage test * [wallet/desktop] task: add test for Account store module * [wallet/desktop] fix: typo * [wallet/desktop] task: update test for AccountMultisigGraph component
yilmazbahadir
pushed a commit
that referenced
this pull request
Aug 9, 2022
…s#1863 (#1881) * [wallet/desktop] fix: cosign form is not presented for multisig tx fix multisig graph action * [wallet/desktop] task: update AccountMultisigGraph test * [wallet/desktop] task: use root and current multisig graph to check if tx needs cosignature * [wallet/desktop] feat: add new multisig graph presentation, fix graph construction * [wallet/desktop] task: update and add tests for AccountMultisigGraph component * [wallet/desktop] task: show multisig graph for cosigners * [wallet/desktop] task: sort multisig graph by address, remove old tree * [wallet/desktop] task: add test for AccountDetailsPage * [wallet/desktop] fix: AccountDetailsPage test * [wallet/desktop] task: add test for Account store module * [wallet/desktop] fix: typo * [wallet/desktop] task: update test for AccountMultisigGraph component
yilmazbahadir
pushed a commit
that referenced
this pull request
Aug 9, 2022
…s#1863 (#1881) * [wallet/desktop] fix: cosign form is not presented for multisig tx fix multisig graph action * [wallet/desktop] task: update AccountMultisigGraph test * [wallet/desktop] task: use root and current multisig graph to check if tx needs cosignature * [wallet/desktop] feat: add new multisig graph presentation, fix graph construction * [wallet/desktop] task: update and add tests for AccountMultisigGraph component * [wallet/desktop] task: show multisig graph for cosigners * [wallet/desktop] task: sort multisig graph by address, remove old tree * [wallet/desktop] task: add test for AccountDetailsPage * [wallet/desktop] fix: AccountDetailsPage test * [wallet/desktop] task: add test for Account store module * [wallet/desktop] fix: typo * [wallet/desktop] task: update test for AccountMultisigGraph component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution