replace old explorer url with the new one and remove edit option #1775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bassemmagdy
requested review from
AnthonyLaw,
yilmazbahadir and
OlegMakarenko
bassemmagdy
changed the title
| @@ -84,6 +84,10 @@ export class SettingsModelStorage extends VersionedObjectStorage<Record<string, | |||
| description: 'Reset for fees update.', | |||
| migrate: () => undefined, | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
- we need reset storage to remove explorer link from there?
- description is wrong
| @@ -42,6 +40,15 @@ | |||
| </template> | |||
| </FormRow> | |||
|
|
|||
| <FormRow> | |||
| <template v-slot:label> {{ $t('set_explorer_link') }}: </template> | |||
There was a problem hiding this comment.
Maybe for consistency with the labels above, we should change it to this:
Suggested change
| <template v-slot:label> {{ $t('set_explorer_link') }}: </template> | |
| <template v-slot:label> {{ $t('form_label_explorer_link') }}: </template> |
Then the translation key should be also updated
|
This pull request introduces 1 alert when merging 89f2961 into e1103f8 - view on LGTM.com new alerts:
|
|
Tested. Works well. |
cryptoBeliever
previously approved these changes
Nov 24, 2021
bassemmagdy
force-pushed
the
gh1766-fix-explorerUrl
branch
from
89f2961
to
840ac21
Compare
|
SonarCloud Quality Gate failed.
|
|
rebased in #1784 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-fixes #1766