Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix transfer form shows not enough balance incorrectly #1774

Merged
merged 1 commit into from
Nov 25, 2021
Merged

Conversation

bassemmagdy
Copy link
Contributor

-fixes #1771

Current Behavior:
open link

const balance =
this.isCosignatoryMode || selectedMosaic.mosaicIdHex !== this.networkConfiguration.currencyMosaicId
? currentMosaicBalance
: (selectedMosaic.balance - this.selectedFeeValue) / Math.pow(10, selectedMosaic.divisibility);
if (currentMosaicBalance == 0 || balance <= 0) {
Copy link
Contributor

@cryptoBeliever cryptoBeliever Nov 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bassemmagdy
Looks like we can change/simplify this line to:

if (balance <= 0) {

could you verify?

Copy link
Contributor Author

@bassemmagdy bassemmagdy Nov 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, updated.

@cryptoBeliever
Copy link
Contributor

From testing all good 👍

@sonarcloud
Copy link

sonarcloud bot commented Nov 19, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bassemmagdy bassemmagdy merged commit 63df281 into dev Nov 25, 2021
@bassemmagdy bassemmagdy deleted the gh1771-fix branch November 25, 2021 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

send- when sending anything other than a currency mosaic, the UI displays there is not enough balance
3 participants