Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction rental fees in a confirmed transaction details modal #488

Closed
bassemmagdy opened this issue Aug 4, 2020 · 1 comment
Closed
Assignees
Labels
enhancement New feature or request story-3 3 Story Points

Comments

@bassemmagdy
Copy link
Contributor

Display rental fees in namespaces/mosaic confirmed transaction details modal.

@bassemmagdy bassemmagdy added enhancement New feature or request story-3 3 Story Points labels Aug 4, 2020
@bassemmagdy bassemmagdy self-assigned this Aug 4, 2020
bassemmagdy added a commit to bassemmagdy/symbol-desktop-wallet that referenced this issue Aug 4, 2020
bassemmagdy added a commit to bassemmagdy/symbol-desktop-wallet that referenced this issue Aug 7, 2020
bassemmagdy added a commit to bassemmagdy/symbol-desktop-wallet that referenced this issue Sep 28, 2020
evias pushed a commit that referenced this issue Sep 30, 2020
* display current rental fee in mosaic and namespace creation

* adding rental fees to form for creating/extending namespaces and mosaics > resolves #356 #357

* linting

* fixing tests for travis build

* Update TransactionView.ts

* refactor componenets + adding fees to confirmed transaction modal #356 #357 #488

* avoiding confirmed transaction in getting rental fees to solve conflict from aggregate transaction pr + solving some eslint warnings

* updates

* fixing mosaic details doesn't load in transaction confirmation modal while creating new mosaics

* bugfix namespace transaction doesn't load details #357 #488 #356

* resolve conflicts

* Creating new version 0.13.1

Co-authored-by: travis@localhost <travis@localhost>
evias added a commit that referenced this issue Sep 30, 2020
* Creating new version 0.13.1

* Mnemonic passphrase QR Code export option added on profile creation (fixes #106)

* Profile creation mnemonic passphrase backup tips design is enhanced (fixes #106)

* Linting (#106)

* i18n keys typo fix

* (fix) Using temporarily stored password to produce MnemonicQR now, fixes #106

* SignerSelector is added to namespace -> create an alias form and SignerFilter is added to namespaces list (fixes #480)

* Create an alias form default signer selected

* index.html and icon paths are fixed(for linux, windows), fixes (#457)

* Display current rental fee enhancement #356 (#489)

* display current rental fee in mosaic and namespace creation

* adding rental fees to form for creating/extending namespaces and mosaics > resolves #356 #357

* linting

* fixing tests for travis build

* Update TransactionView.ts

* refactor componenets + adding fees to confirmed transaction modal #356 #357 #488

* avoiding confirmed transaction in getting rental fees to solve conflict from aggregate transaction pr + solving some eslint warnings

* updates

* fixing mosaic details doesn't load in transaction confirmation modal while creating new mosaics

* bugfix namespace transaction doesn't load details #357 #488 #356

* resolve conflicts

* Creating new version 0.13.1

Co-authored-by: travis@localhost <travis@localhost>

* show expired mosaics in transaction details fixes #279 (#496)

* Gh249 qr codes and uri handling (#510)

* QR Code import feature implemented (fixes #249)

* Missing Copyright notices fixed

* CosignatureQR export/import feature implemented, fixes #249, #504

* Alphabetically sorted the keys in language files, fixes #249, #504

Co-authored-by: Baha <[email protected]>
Co-authored-by: Grégory Saive <[email protected]>

* Bugfix/capitalized label (#518)

* rebase

* fixes #501

* allow msg only transactions without mosaics #474 (#494)

* allow msg only transactions without mosaics #474

* Upgraded SDK to 0.20.8 alpha ; Merged in 0.10 compatibility commits

* Creating new version 0.13.1

Co-authored-by: Gregory Saive <[email protected]>
Co-authored-by: travis@localhost <travis@localhost>

* Csv export (#507)

* utransform data and ui updates for csv export fixes #416

* linting

* fix travis build

* Seprate wallets fixes #221 (#516)

* QR Code import feature implemented (fixes #249)

* Missing Copyright notices fixed

* seperate hd-wallet from private key wallets

Co-authored-by: Baha <[email protected]>

* Added database migrations for v0.10.x Network compatibility (#519)

* Upgraded SDK to 0.21 ; HD & QR to 0.13 ; Added database migrations

* Update profile migration (BREAKING)

* Fixed linter issues

* Gh509 transaction uri import export (#517)

* QR Code import feature implemented (fixes #249)

* Missing Copyright notices fixed

* CosignatureQR export/import feature implemented, fixes #249, #504

* Alphabetically sorted the keys in language files, fixes #249, #504

* Transaction URI import & export feature implemented, fixes #509

* package-lock.json update

Co-authored-by: Baha <[email protected]>

Co-authored-by: travis@localhost <travis@localhost>
Co-authored-by: Baha <[email protected]>
Co-authored-by: Bassem <[email protected]>
Co-authored-by: yilmazbahadir <[email protected]>
@cryptoBeliever
Copy link
Contributor

Estimated rental fee for mosaics and namespaces is presented 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request story-3 3 Story Points
Projects
None yet
Development

No branches or pull requests

2 participants