Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid profile should can be reset #353

Closed
David0817 opened this issue May 13, 2020 · 3 comments · Fixed by #373
Closed

Invalid profile should can be reset #353

David0817 opened this issue May 13, 2020 · 3 comments · Fixed by #373
Assignees
Labels
needs reproduction This issue has not be reproduced yet, may need more information

Comments

@David0817
Copy link
Contributor

David0817 commented May 13, 2020

  1. In the app, when the registration or import is larger than the first step, and then the app is closed, invalid profile will be saved
  2. In the web, when the registration or import is larger than the first step and the page is refreshed, invalid profile will be saved and the back button will not work

The above invalid profile should be allowed to be re-registered or imported

  1. The login page should not display invalid profile in the list
  2. When registering, step 3 Backup Mnemonic Phrase should go straight back to step 1 Create Profile and delete current profile
@evias
Copy link
Contributor

evias commented May 18, 2020

I don't understand what it means for a registration to be larger ? Please elaborate.

Also, instead of deleting the profile, 4) should simply redirect the user where he left of.

@evias evias added the needs reproduction This issue has not be reproduced yet, may need more information label May 18, 2020
@David0817
Copy link
Contributor Author

@evias
registration 5 steps

  1. The Create Profile college
  2. Generate Mnemonic college
  3. Backup Mnemonic Phrase college
  4. Verify Mnemonic Phrase college
  5. Finish

Import 4 steps

  1. The Create Profile
  2. The Mnemonic Passphrase college
  3. Select the Accounts college
    4 Finish

When the first step is completed (the Profile has been stored) and go to other steps , the invalid profile is left when the unexpected exits.

When I enter next time, the last incomplete profile may be right, but I don't want to complete or i want to chose import. there is no button to jump to base guide page.my idea is that I can continue to register or import with the same profile, rather than jump to the last exit step. Because the frequency of registration is not that high.

@David0817
Copy link
Contributor Author

David0817 commented May 19, 2020

WeChat56cc15d25ab49683b4b2d01c8e4e33f5

WeChatd512bed8d02a4599f2b36de5f5f92e39

When I was in the third step, now I can only back to Generate Mnemonic. I think it can skip the second step and go back to the first step to reset the profile.

David0817 added a commit to JeRaytheon/symbol-desktop-wallet that referenced this issue May 20, 2020
  * change button name (fix symbol#341)
  * invalid profile was removed from the login list (fixes symbol#353)
  * the profile can be reset after an unexpected exit
David0817 added a commit to JeRaytheon/symbol-desktop-wallet that referenced this issue May 20, 2020
  * change button name (fix symbol#341)
  * invalid profile was removed from the login list (fixes symbol#353)
  * the profile can be reset after an unexpected exit
David0817 added a commit to JeRaytheon/symbol-desktop-wallet that referenced this issue May 22, 2020
  * change button name (fix symbol#341)
  * invalid profile was removed from the login list (fixes symbol#353)
  * the profile can be reset after an unexpected exit
evias pushed a commit to JeRaytheon/symbol-desktop-wallet that referenced this issue May 27, 2020
  * change button name (fix symbol#341)
  * invalid profile was removed from the login list (fixes symbol#353)
  * the profile can be reset after an unexpected exit
evias pushed a commit that referenced this issue May 27, 2020
* change button name (fix #341)
  * invalid profile was removed from the login list (fixes #353)
  * the profile can be reset after an unexpected exit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs reproduction This issue has not be reproduced yet, may need more information
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants