Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metadata transaction details view #1838

Closed
cryptoBeliever opened this issue Feb 11, 2022 · 2 comments
Closed

Metadata transaction details view #1838

cryptoBeliever opened this issue Feb 11, 2022 · 2 comments
Assignees
@yilmazbahadir

Comments

@cryptoBeliever
Copy link
Contributor

When we are sending Metadata transactions in value field, we have a delta (xor) compared to the previous value. So:

  • when we create new metadata for the account/mosaic/namespace we send the entire value (since there is no previous one)
  • when we edit existing metadata we are sending just value change

The wallet is trying to present value change (in the case of edition) as a utf-8 text which causes invalid presentation.
In transaction details view we should:

  • always present binary (hex) representation of value change
  • text value shows only if it's possible to decode it
  • rename "Value" to "Value delta" or "Value change"
  • also "ScopedMetadataKey" and "ValueSizeDelta" could be changed to "Scoped Metadata Key" and "Value Size Delta"
  • we have two times ScopedMetadataKey which I think is redundant?

Example tx view:
image
@yilmazbahadir yilmazbahadir self-assigned this Feb 12, 2022
yilmazbahadir pushed a commit that referenced this issue Feb 13, 2022
fix: metadata non-ascii text update failure, views refresh issue, det…
cf9a0b1 
…ails view fixed, fixes #1837, #1838
@yilmazbahadir yilmazbahadir mentioned this issue Feb 13, 2022
Merged
yilmazbahadir pushed a commit that referenced this issue Feb 14, 2022
fix: metadata non-ascii text update failure, views refresh issue, det…
3035e8c 
…ails view fixed, fixes #1837, #1838
@cryptoBeliever
Copy link
Contributor Author

Fixed in #1839

yilmazbahadir added a commit that referenced this issue Mar 4, 2022
@yilmazbahadir
fix: metadata non-ascii text update failure, views refresh issue, det… (
805c33c 
#1839)

* fix: metadata non-ascii text update failure, views refresh issue, details view fixed, fixes #1837, #1838

* linting fixes in language files

* fix: metadata value renamed to value delta in transaction details view

* upgrade symbol-sdk to latest alpha - for metadata changes

* fix: added unit tests for account, mosaic and namespace transaction detail views

* whitespace issue in the language files is fixed

* update symbol-sdk to the latest alpha

* fix: symbol-sdk updated to v2.0.0

* fix: japanese, chinese and russian lang updates

Co-authored-by: Baha <[email protected]>
@cryptoBeliever
Copy link
Contributor Author

Released in 1.0.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yilmazbahadir yilmazbahadir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yilmazbahadir @cryptoBeliever