Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer Form. Improve mosaic amount input #1562

Closed
OlegMakarenko opened this issue Jun 25, 2021 · 5 comments · Fixed by #1745
Closed

Transfer Form. Improve mosaic amount input #1562

OlegMakarenko opened this issue Jun 25, 2021 · 5 comments · Fixed by #1745
Assignees
Labels

Comments

@OlegMakarenko
Copy link
Contributor

  • Display mosaic balance in the amount text box
  • Display an error message when the transfer amount exceeds the balance

image

@coiki
Copy link

coiki commented Aug 25, 2021

User Story

As a user that wants to send mosaics,
I want to be warned when I want to send more mosaics than I currently hold,
so I can make adjustments when needed.

Acceptance Criteria

AC1. We will show a non-intrusive validation alert when the amount typed in the box, is higher than the current available balance.
AC2. We will not block the action of attempting to send, and will wait to receive a REST error if the user wants to send a higher amount. This is to avoid issues with source of truth.

This task comes from an Out of scope from #1530.

@cryptoBeliever
Copy link
Contributor

The only problem I've found is that currently we are blocking "Send" button when the amount is too big which is not correct according AC2 (#1562 (comment))

@cryptoBeliever
Copy link
Contributor

Currently validation is still on wallet side: https://share.getcloudapp.com/jku4GXyk

@cryptoBeliever
Copy link
Contributor

cryptoBeliever commented Sep 27, 2021

@bassemmagdy
There is also small issue in offline txs (it does not allow to create offline tx):

image

bassemmagdy added a commit that referenced this issue Oct 14, 2021
@cryptoBeliever
Copy link
Contributor

Looks good in PR #1745 👍

This was referenced Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment