Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Could add address next to alias in confirmation screen for clarity. #1151

Closed
jabo38 opened this issue Feb 16, 2021 · 1 comment · Fixed by #1631
Closed

Could add address next to alias in confirmation screen for clarity. #1151

jabo38 opened this issue Feb 16, 2021 · 1 comment · Fixed by #1631
Assignees
@bassemmagdy
Labels
enhancement New feature or request

Comments

@jabo38
Copy link

jabo38 commented Feb 16, 2021

Is your feature request related to a problem? Please describe.
No problem really, just a very small thing that could make the wallet nicer

Describe the solution you'd like
When I send a tx by alias, it could be nice to confirm the address in the confirmation screen, just in case I mistyped or something.

Describe alternatives you've considered
I made a mockup below of how it could work.

image
@cryptoBeliever cryptoBeliever added the enhancement New feature or request label Feb 17, 2021
bassemmagdy added a commit that referenced this issue Aug 4, 2021
@bassemmagdy
added address next to alias in confirmation screen for clarity #1151
2886226
@bassemmagdy bassemmagdy mentioned this issue Aug 4, 2021
Merged
@AnthonyLaw AnthonyLaw assigned bassemmagdy and unassigned boldchains Aug 6, 2021
@cryptoBeliever
Copy link
Contributor

Fixed in dev. Closed.

@bassemmagdy bassemmagdy mentioned this issue Aug 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassemmagdy bassemmagdy

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added address next to alias in confirmation screen for clarity symbol/desktop-wallet
4 participants
@bassemmagdy @jabo38 @cryptoBeliever @boldchains