Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DC-219 Make API endpoints page more visible for Async APIs #394

Merged
merged 12 commits into from
Mar 3, 2022

Conversation

Mukulikaa
Copy link
Contributor

@Mukulikaa Mukulikaa commented Mar 2, 2022

Type of Pull Request

  • 🎉 Feature Enhancement
  • 🐛 Bug Fix
  • 📖 Documentation Update
  • ❇️ Other

Description

Added a link to the API Reference page from the Introduction page of Async API as it is otherwise not reachable. I did not feel it was good to separate Supported Languages into a different page as it is part of the API reference. I also didn't think it would be proper to restructure the page as suggested in the issue as the order of items looks good to me right now. I am happy to hear differing opinions on this.

EDIT:
After review, it has been decided to have Supported Languages in a separate page and the endpoints have been moved to Introduction.

Issue

DC-219

@Mukulikaa Mukulikaa requested review from mjabali and pema-s March 2, 2022 11:16
Copy link
Contributor

@pema-s pema-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pema-s pema-s merged commit 905d1ec into symblai:master Mar 3, 2022
avoliva pushed a commit that referenced this pull request Mar 3, 2022
pema-s added a commit that referenced this pull request Mar 4, 2022
* Fix build.

* Fix build. (#392)

* Reverts the last commit (#393)

* DC-321 (#395)

* DC-321

* Update reference.md

* DC-219 Make API endpoints page more visible for Async APIs (#394)

* change for exp branch

* merge-docs-v1 added for build to workflow

* changes for dev and prod dispatch events

* Testing changes

* DC-219 Make API endpoints page more visible for Async APIs

* DC-219 Split Async API page into two pages

Co-authored-by: harshad-symbl <[email protected]>
Co-authored-by: Adam Voliva <[email protected]>
Co-authored-by: amritesh-singh <[email protected]>

* DC-211 Added interlinking between live captioning, insights and topics (#398)

* change for exp branch

* merge-docs-v1 added for build to workflow

* changes for dev and prod dispatch events

* Testing changes

* DC-211 Added interlinking between live captioning, insights and topics

Co-authored-by: harshad-symbl <[email protected]>
Co-authored-by: Adam Voliva <[email protected]>
Co-authored-by: amritesh-singh <[email protected]>

* Fix the compilation error (#387)

The code sample does not run due to additional paranthesis. Fixed it

* Updates sidebar.js (#407)

* Revert "Updates sidebar.js (#407)"

This reverts commit 346425e.

* Revert "Fix the compilation error (#387)"

This reverts commit d6525d3.

* Revert "DC-211 Added interlinking between live captioning, insights and topics (#398)"

This reverts commit c1513d3.

* Revert "DC-219 Make API endpoints page more visible for Async APIs (#394)"

This reverts commit 905d1ec.

* Revert "DC-321 (#395)"

This reverts commit ca217bc.

* Revert "Fix build. (#392)"

This reverts commit b28e6e4.

* Revert "DC-120 (#385)"

This reverts commit 74c36f0.

* Revert "DC-220 Minor wording change to conform to styleguide (#384)"

This reverts commit 5a01612.

* Revert "DC-284 (#378)"

This reverts commit 4aa2b5d.

* Revert "Merge pull request #409 from symblai/reverting"

This reverts commit 9a47075, reversing
changes made to 5d54f79.

* trigger build.

* REmove sidebar customizations.

* Fix docsidebaritem.

Co-authored-by: avoliva <[email protected]>
Co-authored-by: Pema <[email protected]>
Co-authored-by: Amritesh Singh <[email protected]>
Co-authored-by: Mukulika <[email protected]>
Co-authored-by: harshad-symbl <[email protected]>
Co-authored-by: warunawijesinhaarachchige <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants