FIX Handle array style email config #395
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
GuySartorelli
requested changes
Jan 25, 2023
| if (count($email) === 0) { | ||
| throw new InvalidArgumentException('Empty array passed for $email'); | ||
| } | ||
| return array_keys($email)[0]; |
There was a problem hiding this comment.
This will essentially just throw away the "name" part of the email address, which is not the expected behaviour.
There was a problem hiding this comment.
Having a look through https://github.com/silverstripe/silverstripe-framework/blob/5/src/Control/Email/Email.php - looks like we may have accidentally lost support for the "Name" portion of array config during the upgrade to symfony/mailer e.g. https://github.com/silverstripe/silverstripe-framework/blob/5/src/Control/Email/Email.php#L206 will also remove the "Name" portion
Given that we should probably add support back in to Email rather than fixing this here
This was referenced Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-framework#10618