NEW Extend new AbstractGridFieldComponent class #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that tests will error until a 4.11 branch or tag is available in silverstripe/silverstripe-framework |
GuySartorelli
force-pushed
the
enh/gridfieldcomponents-di
branch
from
a4f5976 to
b27b089
Compare
|
Could you please run |
GuySartorelli
force-pushed
the
enh/gridfieldcomponents-di
branch
from
b27b089 to
c5d2b6e
Compare
|
@emteknetnz Done! |
This makes the `GridFieldQueuedJobExecute` component `Injectable`, and allows any future enhancements in the new abstract class to automatically apply without requiring additional changes in this module. The class is introduced in silverstripe/framework 4.11.0 so the dependency constraint needs to be updated.
GuySartorelli
force-pushed
the
enh/gridfieldcomponents-di
branch
from
c5d2b6e to
d2e0488
Compare
|
Fixed phpcs linting issue. |
michalkleiner
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the
GridFieldQueuedJobExecutecomponentInjectable, and allows any future enhancements in the new abstract class to automatically apply without requiring additional changes in this module.The class is introduced in silverstripe/framework 4.11.0 (see silverstripe/silverstripe-framework#10204) so the dependency constraint needs to be updated.