Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to support PHPStan 0.9 #8

Merged
merged 1 commit into from
Apr 19, 2018
Merged

Update to support PHPStan 0.9 #8

merged 1 commit into from
Apr 19, 2018

Conversation

grantlucas
Copy link
Contributor

Version 0.9 of PHPStan included a number of BC breaks. These changes update it to get in line with the latest major version, 0.9.

[Version 0.9 of
PHPStan](https://github.com/phpstan/phpstan/releases/tag/0.9) included a
number of BC breaks. These changes update it to get in line with the
latest major version, `0.9`.
@silbinarywolf
Copy link
Contributor

silbinarywolf commented Apr 19, 2018

@grantlucas Awesome!
I'll have this reviewed and most likely merged by the 23rd at the latest.

The aim is to hopefully have this in by tonight though. Cheers.

@silbinarywolf silbinarywolf merged commit 81b4e7c into symbiote:master Apr 19, 2018
@grantlucas grantlucas deleted the phpstan-version-9 branch April 19, 2018 17:39
@grantlucas
Copy link
Contributor Author

@silbinarywolf Thanks! Would it be possible to get a new release tagged?

@silbinarywolf
Copy link
Contributor

@grantlucas Hoping to do so in the next few days. I want to fix the incorrect documentation + put in my ClassConst fixes in:
https://github.com/silbinarywolf/silverstripe-phpstan/tree/dev-fix-chaining

@silbinarywolf
Copy link
Contributor

@grantlucas Actually for your convenience, I'll just tag it with 0.2 now. Will tag 0.3 in a couple of days :)

@grantlucas
Copy link
Contributor Author

Thanks! Looking forward to future changes. We've just started using PHPStan, and still have a lot of code to get through to clean up, so we'll be making good use of your integration and making PRs for any issues we can

silbinarywolf added a commit that referenced this pull request Apr 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants