ENH Update translations #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
emteknetnz
requested changes
Mar 9, 2023
| @@ -243,7 +243,11 @@ | |||
| const classes = this.data('classes'); | |||
| const liHtml = Object.keys(classes).map(className => { | |||
| const link = hrefTemplate.replace('{class}', className); | |||
| return `<li><a href="${link}">Add: <i>${classes[className]}</i></a></li>`; | |||
| const linkText = ss.i18n.inject( | |||
There was a problem hiding this comment.
If we're changing this then shouldn't there be an updated bundle.js too?
There was a problem hiding this comment.
Why? This is just making strings translatable. It doesn't affect how (or even if) it's transpiled.
There was a problem hiding this comment.
We'll if there was a bundle.js we'd need to update it so that translations were actually used :-)
It's a non issue though
Requirements::javascript('symbiote/silverstripe-gridfieldextensions:javascript/GridFieldExtensions.js');
emteknetnz
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add to transifex: https://www.transifex.com/silverstripe/silverstripe-gridfieldextensions/
Note that the
javascript/andcss/files not being insideclient/is unusual, but it's not something we can change in this major release line.I missed it in the CMS 5 lineup so I'll raise a new card to deal with it for that release line.
Issue