ENH: Add performance fixes on saving editable columns #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satrun77
force-pushed
the
pull/performance-fixes
branch
from
33b16f1 to
8b2a541
Compare
emteknetnz
requested changes
Jun 15, 2022
There was a problem hiding this comment.
If we change the protected method to private then there's no API change so we can do a patch release meaning we release it much faster.
Please rebase/retarget to the 3.4 branch
Also prefix your commit message and the title of the PR with ENH as this is an enhancement
satrun77
force-pushed
the
pull/performance-fixes
branch
from
8b2a541 to
3334a66
Compare
satrun77
changed the title
emteknetnz
requested changes
Jun 16, 2022
src/GridFieldEditableColumns.php
Outdated
|
|
||
| if (!$item || !$item->canEdit()) { | ||
| // Skip not found item, or don't have any changed fields, or current user can't edit | ||
| if (!$item || !$this->isChanged($item, $fields) || !$item-canEdit()) { |
There was a problem hiding this comment.
Suggested change
| if (!$item || !$this->isChanged($item, $fields) || !$item-canEdit()) { | |
| if (!$item || !$this->isChanged($item, $fields) || !$item->canEdit()) { |
- Use one query to fetch all items needed to be saved. - Only save items that are changed.
satrun77
force-pushed
the
pull/performance-fixes
branch
from
3334a66 to
547ec8a
Compare
emteknetnz
approved these changes
Jun 16, 2022
|
I've released 3.4.1 for you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in the PR to address the issue described in silverstripe/silverstripe-userforms#773
This might not eliminate the issue completely, but it is an improvement to the current code.
Changes include,