Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/republish live records 3 #334

Merged

Conversation

josephlewisnz
Copy link
Contributor

Added the ability to autopublish items that are already live
Same request #289 for 3 Branch

Copy link
Contributor

@dhensby dhensby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks.

It would be great to have a test to cover this functionality too

src/GridFieldOrderableRows.php Outdated Show resolved Hide resolved
@josephlewisnz
Copy link
Contributor Author

Regarding tests, I'm not the most experienced in that space. I could try taking a stab at it sometime late next week.

@purplespider
Copy link

Can we please get this merged, @dhensby?

People have literally been trying for years to get it merged into the correct branch and a release: #289, #339, #340 😮‍💨 And for those of us pointing composer to the specific commit it's become an upgrade blocker.

Thank you! 🤞🏻

@dhensby
Copy link
Contributor

dhensby commented Nov 15, 2022

I don't have merge permissions on the symbiote repos anymore - I can't merge this, I'm afraid

@purplespider
Copy link

@sabina-talipova Are you able to assist with merging this?

@maxime-rainville maxime-rainville merged commit d5d438c into symbiote:3 Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants