fix(PruneChangesBeforeJob): Remove unused / old code that retrieved a… #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… flat list of IDs as this can cause the job to not work if there are a lot of DataChangeRecord items. (#18) fix(PruneChangesBeforeJob): Fix logic of priorTo so that it defaults to the last 3 months properly fix(PruneChangesBeforeJob): Change steps to 1 as it's technically doing this in 1 step now, this is to avoid an issue where totalSteps=0 can occur and the job won't requeue itself. (cherry picked from commit b0a0c97)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… flat list of IDs as this can cause the job to not work if there are a lot of DataChangeRecord items. (#18)
fix(PruneChangesBeforeJob): Fix logic of priorTo so that it defaults to the last 3 months properly
fix(PruneChangesBeforeJob): Change steps to 1 as it's technically doing this in 1 step now, this is to avoid an issue where totalSteps=0 can occur and the job won't requeue itself.
(cherry picked from commit b0a0c97)