Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type on Strap v2 #187

Closed
sylhare opened this issue Sep 8, 2019 · 3 comments
Closed

Type on Strap v2 #187

sylhare opened this issue Sep 8, 2019 · 3 comments
Assignees

Comments

@sylhare
Copy link
Owner

sylhare commented Sep 8, 2019

Preparation for the version 2 which will use Jekyll v4.0

@sylhare sylhare self-assigned this Sep 8, 2019
@mhagnumdw
Copy link
Contributor

Can you talk a bit about Type on Strap v2 and Jekyll v4.0? News, improvements etc

@sylhare
Copy link
Owner Author

sylhare commented Sep 9, 2019

Allo @mhagnumdw

From Jekyll here what 4.0 brings:

Ruby 2.4.0 or greater is now required.
Rouge 3.0 or greater is now required for syntax highlighting.
Jekyll builds should be much faster.
Kramdown 2.1 is now the default markdown engine.
Sass processing should be faster.
Dropped support for a lot of stuff, specifically: (Pygments, RedCarpet, RDiscount)

There are also some changes in the liquid tags, so far on my tests, everything seems to be working fine as is.

I will also take on this opportunity to:

  • Rearrange _config.yml using the _data folder which might impact the user as some changes will need to occur on the user's side.
  • More language support (To easily switch the theme to english or french or more)
  • Update jekyll plugins
  • Update the gemspec
  • Open the possibility to simplify theme with what brings Jekyll 4.0

sylhare added a commit that referenced this issue Sep 14, 2019
sylhare added a commit that referenced this issue Sep 14, 2019
sylhare added a commit that referenced this issue Sep 14, 2019
sylhare added a commit that referenced this issue Sep 14, 2019
sylhare added a commit that referenced this issue Sep 14, 2019
sylhare added a commit that referenced this issue Sep 14, 2019
sylhare added a commit that referenced this issue Sep 21, 2019
sylhare added a commit that referenced this issue Sep 22, 2019
@sylhare
Copy link
Owner Author

sylhare commented Sep 22, 2019

The new version is ready, should be merged into Master soon.
I have added some retro compatibility.

However a couple of adjustment need to be made regarding the theme settings #17 :

# THEME-SPECIFIC CONFIGURATION
theme_settings:
  # Meta
  avatar: assets/img/triangle.png
  color_image: /assets/img/lineart.png # In post when you set color
  favicon: assets/favicon.ico

  # Header and footer text
  header_text: Change header text in <code>_config.yml</code>
  header_feature_image: assets/img/pexels/triangular.jpeg

Will need to be transformed into:

# THEME-SPECIFIC CONFIGURATION
avatar: assets/img/triangle.png                         # Empty for no avatar in navbar
favicon: assets/favicon.ico                             # Icon displayed in the tab
header_text:                                            # Change Blog header text
header_feature_image: assets/img/pexels/triangular.jpeg
color_image: /assets/img/lineart.png                    # A bit transparent for color posts.

For the rest, it can coexist no problems, but for any customization, it will need to go through the new way (using _data and without the theme_settings: in the yaml).

sylhare added a commit that referenced this issue Oct 1, 2019
sylhare added a commit that referenced this issue Oct 1, 2019
sylhare added a commit that referenced this issue Oct 2, 2019
@sylhare sylhare closed this as completed Oct 3, 2019
OMEGA-Y pushed a commit to OMEGA-Y/OMEGA-Y.github.io that referenced this issue Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants