Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add DeleteObjects #374

Merged
merged 1 commit into from
Jul 9, 2024
Merged

feat: add DeleteObjects #374

merged 1 commit into from
Jul 9, 2024

Conversation

tri-adam
Copy link
Member

@tri-adam tri-adam commented Jul 4, 2024

Add DeleteObjects, which allows the caller to delete one or more data objects that match a DescriptorSelectorFunc.

Closes #372

@tri-adam tri-adam self-assigned this Jul 4, 2024
@tri-adam tri-adam changed the title Delete objects feat: add DeleteObjects Jul 4, 2024
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 89.65517% with 3 lines in your changes missing coverage. Please review.

Project coverage is 62.80%. Comparing base (94b0b65) to head (68683b4).

Files Patch % Lines
pkg/sif/delete.go 88.46% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #374      +/-   ##
==========================================
+ Coverage   62.64%   62.80%   +0.16%     
==========================================
  Files          37       37              
  Lines        3234     3248      +14     
==========================================
+ Hits         2026     2040      +14     
  Misses       1043     1043              
  Partials      165      165              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tri-adam tri-adam force-pushed the delete-objects branch 3 times, most recently from 4b8d53e to 89fbce1 Compare July 9, 2024 15:54
Add DeleteObjects, which allows the caller to delete one or more data
objects that match a DescriptorSelectorFunc.
@tri-adam tri-adam marked this pull request as ready for review July 9, 2024 16:10
Copy link
Member

@dtrudg dtrudg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tri-adam tri-adam merged commit a2a8352 into sylabs:main Jul 9, 2024
1 check passed
@tri-adam tri-adam deleted the delete-objects branch July 9, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add DeleteObjects API
2 participants