Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add SetOCIBlobDigest #365

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

tri-adam
Copy link
Member

(Based on top of #364, will re-base once that is merged)

Add SetOCIBlobDigest, which allows the caller to set the digest of an OCI blob that is embedded within the "extra" field of the descriptor. This will support specialized use cases such as the ones discussed in sylabs/oci-tools#48.

@tri-adam tri-adam self-assigned this Jun 18, 2024
@tri-adam tri-adam changed the title Set blob digest feat: add SetOCIBlobDigest Jun 18, 2024
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 59.45946% with 15 lines in your changes missing coverage. Please review.

Project coverage is 62.59%. Comparing base (3c091b8) to head (b85400b).

Files Patch % Lines
pkg/sif/set.go 55.88% 10 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #365      +/-   ##
==========================================
- Coverage   62.65%   62.59%   -0.06%     
==========================================
  Files          37       37              
  Lines        3245     3280      +35     
==========================================
+ Hits         2033     2053      +20     
- Misses       1046     1056      +10     
- Partials      166      171       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tri-adam tri-adam marked this pull request as ready for review June 18, 2024 19:53
Copy link
Member

@dtrudg dtrudg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tri-adam tri-adam merged commit d63ee14 into sylabs:main Jun 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants