Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump golangci-lint to v1.57 #357

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Conversation

tri-adam
Copy link
Member

@tri-adam tri-adam commented Mar 21, 2024

Bump golangci-lint to v1.57. Add copyloopvar and intrange, which won't come into play until this module adopts Go 1.22 but play nicely with Go 1.21. Drop loop variable usage in (non-parallel) tests, which is safe for Go 1.21 and will lessen the number of changes required for a clean copyloopvar run when Go 1.22 is adopted.

Add patch version to go directive in go.mod (see golang/go#62278).

@tri-adam tri-adam self-assigned this Mar 21, 2024
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.26%. Comparing base (796011b) to head (60d5791).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #357   +/-   ##
=======================================
  Coverage   65.26%   65.26%           
=======================================
  Files          34       34           
  Lines        3245     3245           
=======================================
  Hits         2118     2118           
  Misses        974      974           
  Partials      153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Enable copyloopvar and intrange linters. They won't activate until the
module adopts Go 1.22, but run cleanly at the moment.
.golangci.yml Show resolved Hide resolved
@tri-adam tri-adam marked this pull request as ready for review March 26, 2024 17:14
@tri-adam tri-adam merged commit 04ef116 into sylabs:main Mar 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants