Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused params in function literals #352

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

tri-adam
Copy link
Member

@tri-adam tri-adam commented Feb 8, 2024

revive linter now checks for this as of v1.3.7.

revive linter now checks for this as of v1.3.7.
@tri-adam tri-adam self-assigned this Feb 8, 2024
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4960f05) 65.27% compared to head (418fb7a) 65.27%.

Files Patch % Lines
cmd/siftool/siftool.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #352   +/-   ##
=======================================
  Coverage   65.27%   65.27%           
=======================================
  Files          34       34           
  Lines        3266     3266           
=======================================
  Hits         2132     2132           
  Misses        978      978           
  Partials      156      156           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tri-adam tri-adam marked this pull request as ready for review February 8, 2024 18:59
@tri-adam tri-adam merged commit 7cf41e5 into sylabs:main Feb 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants