Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate user package #325

Merged
merged 1 commit into from
Sep 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions internal/app/siftool/mount.go

This file was deleted.

20 changes: 0 additions & 20 deletions internal/app/siftool/unmount.go

This file was deleted.

27 changes: 0 additions & 27 deletions pkg/siftool/mount.go

This file was deleted.

61 changes: 0 additions & 61 deletions pkg/siftool/mount_test.go

This file was deleted.

5 changes: 0 additions & 5 deletions pkg/siftool/siftool.go
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,5 @@ func AddCommands(cmd *cobra.Command, opts ...CommandOpt) error {
c.getSetPrim(),
)

if c.opts.experimental {
cmd.AddCommand(c.getMount())
cmd.AddCommand(c.getUnmount())
}

return nil
}
6 changes: 1 addition & 5 deletions pkg/siftool/siftool_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ func makeTestSIF(t *testing.T, withDataObject bool) string {
return tf.Name()
}

//nolint:unparam
func runCommand(t *testing.T, cmd *cobra.Command, args []string, wantErr error) {
t.Helper()

Expand Down Expand Up @@ -117,11 +118,6 @@ func TestAddCommands(t *testing.T) {
name: "SetPrim",
args: []string{"help", "setprim"},
},
{
name: "Mount",
opts: []CommandOpt{OptWithExperimental(true)},
args: []string{"help", "mount"},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
Expand Down
Empty file.
10 changes: 0 additions & 10 deletions pkg/siftool/testdata/TestAddCommands/Mount/out.golden

This file was deleted.

This file was deleted.

9 changes: 0 additions & 9 deletions pkg/siftool/testdata/Test_command_getMount/Empty/out.golden

This file was deleted.

Empty file.
Empty file.
Empty file.
Empty file.
27 changes: 0 additions & 27 deletions pkg/siftool/unmount.go

This file was deleted.

42 changes: 0 additions & 42 deletions pkg/siftool/unmount_test.go

This file was deleted.

3 changes: 2 additions & 1 deletion pkg/user/mount.go
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
// Copyright (c) 2022, Sylabs Inc. All rights reserved.
// Copyright (c) 2022-2023, Sylabs Inc. All rights reserved.
// This software is licensed under a 3-clause BSD license. Please consult the
// LICENSE file distributed with the sources of this project regarding your
// rights to use or distribute this software.

// Deprecated: this package will be removed in a future version.
package user

import (
Expand Down