test: add testing against Go 1.20 RC #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #250 +/- ##
=======================================
Coverage 72.78% 72.78%
=======================================
Files 35 35
Lines 2862 2862
=======================================
Hits 2083 2083
Misses 626 626
Partials 153 153 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
tri-adam
force-pushed
the
go-1.20rc
branch
2 times, most recently
from
dc2fdb5 to
66958b2
Compare
Signatures generated by the crypto/ecdsa package are not deterministic, so the golden file pattern should not be used with ECDSA keys.
dtrudg
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove ECDSA usage from
Test_dsseEncoder_signMessage, since signatures generated with thecrypto/ecdsapackage are not deterministic. Start testing against Go 1.20 RCs in CI.