feat: RemoveBlob / RemoveDescriptors #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtrudg
force-pushed
the
issue84
branch
2 times, most recently
from
4a1bc4e
to
4690c12
Compare
dtrudg
changed the title
tri-adam
reviewed
Sep 30, 2024
dtrudg
force-pushed
the
issue84
branch
3 times, most recently
from
6c89e79
to
53645a6
Compare
Implement `RemoveBlob` to remove a blob from the SIF without updating the RootIndex. Implement `RemoveDescriptors` to remove specified descriptors from the SIF RootIndex, and clean up any orphan blobs. In order that `RemoveDescriptors` can be run without requiring a temp dir, the update code is modified so that cache directory creation is lazy. Fixes sylabs#84
tri-adam
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
RemoveBlobto remove a blob from the SIF without updating the RootIndex.Implement
RemoveDescriptorsto remove specified descriptors from the SIF RootIndex, and clean up any orphan blobs.In order that
RemoveDescriptorscan be run without requiring a temp dir, the update code is modified so that cache directory creation is lazy.Fixes #84