Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AppendImage/Index #83

Closed
dtrudg opened this issue Sep 26, 2024 · 0 comments · Fixed by #87
Closed

AppendImage/Index #83

dtrudg opened this issue Sep 26, 2024 · 0 comments · Fixed by #87
Assignees
@dtrudg

Comments

@dtrudg
Copy link
Member

dtrudg commented Sep 26, 2024 •
edited
Loading

After #80 we have a public OCIFileImage type that offers an interface for interacting with an OCI-SIF below that of v1.ImageIndex.

The current WriteImage / WriteIndex functions add the blobs for an Image / ImageIndex to an OCI-SIF, but do not update the rootIndex.

Add Append functions for an image / index, which both write blobs and update the RootIndex.

The functions should be patterned on those in ggcr's layout.Path.

func (l Path) AppendImage(img v1.Image, options ...Option) error
func (l Path) AppendIndex(ii v1.ImageIndex, options ...Option) error
@dtrudg dtrudg self-assigned this Sep 26, 2024
This was referenced Sep 26, 2024
Closed
Merged
@dtrudg dtrudg changed the title AppendDescriptor/Image/Index AppendImage/Index Sep 27, 2024
dtrudg added a commit to dtrudg/oci-tools that referenced this issue Sep 27, 2024
@dtrudg
feat: AppendImage/Index with optional name.Reference
95bfcda 
Adds `f.AppendImage` and `f.AppendIndex`, which append a `v1.Image` or a
`v1.ImageIndex` to the SIF, respectively.

The `OptAppendReference` functional option can be used to provide a
`name.Reference` that will be stored as an annotation against the new
descriptor in the RootIndex, with the key
`org.opencontainers.image.ref.name`, as is convention for associating
references with items stored in an OCI layout.

Fixes sylabs#83
Fixes sylabs#81
@dtrudg dtrudg mentioned this issue Sep 27, 2024
Merged
dtrudg added a commit to dtrudg/oci-tools that referenced this issue Sep 27, 2024
@dtrudg
feat: AppendImage/Index with optional name.Reference
cd3697a 
Adds `f.AppendImage` and `f.AppendIndex`, which append a `v1.Image` or a
`v1.ImageIndex` to the SIF, respectively.

The `OptAppendReference` functional option can be used to provide a
`name.Reference` that will be stored as an annotation against the new
descriptor in the RootIndex, with the key
`org.opencontainers.image.ref.name`, as is convention for associating
references with items stored in an OCI layout.

Fixes sylabs#83
Fixes sylabs#81
dtrudg added a commit to dtrudg/oci-tools that referenced this issue Sep 27, 2024
@dtrudg
feat: AppendImage/Index with optional name.Reference
5ee8525 
Adds `f.AppendImage` and `f.AppendIndex`, which append a `v1.Image` or a
`v1.ImageIndex` to the SIF, respectively.

The `OptAppendReference` functional option can be used to provide a
`name.Reference` that will be stored as an annotation against the new
descriptor in the RootIndex, with the key
`org.opencontainers.image.ref.name`, as is convention for associating
references with items stored in an OCI layout.

Fixes sylabs#83
Fixes sylabs#81
dtrudg added a commit to dtrudg/oci-tools that referenced this issue Sep 27, 2024
@dtrudg
feat: AppendImage/Index with optional name.Reference
99dd119 
Adds `f.AppendImage` and `f.AppendIndex`, which append a `v1.Image` or a
`v1.ImageIndex` to the SIF, respectively.

The `OptAppendReference` functional option can be used to provide a
`name.Reference` that will be stored as an annotation against the new
descriptor in the RootIndex, with the key
`org.opencontainers.image.ref.name`, as is convention for associating
references with items stored in an OCI layout.

Fixes sylabs#83
Fixes sylabs#81
dtrudg added a commit to dtrudg/oci-tools that referenced this issue Sep 27, 2024
@dtrudg
feat: AppendImage/Index with optional name.Reference
763ab58 
Adds `f.AppendImage` and `f.AppendIndex`, which append a `v1.Image` or a
`v1.ImageIndex` to the SIF, respectively.

The `OptAppendReference` functional option can be used to provide a
`name.Reference` that will be stored as an annotation against the new
descriptor in the RootIndex, with the key
`org.opencontainers.image.ref.name`, as is convention for associating
references with items stored in an OCI layout.

Fixes sylabs#83
Fixes sylabs#81
dtrudg added a commit to dtrudg/oci-tools that referenced this issue Sep 27, 2024
@dtrudg
feat: AppendImage/Index with optional name.Reference
99f75e5 
Adds `f.AppendImage` and `f.AppendIndex`, which append a `v1.Image` or a
`v1.ImageIndex` to the SIF, respectively.

The `OptAppendReference` functional option can be used to provide a
`name.Reference` that will be stored as an annotation against the new
descriptor in the RootIndex, with the key
`org.opencontainers.image.ref.name`, as is convention for associating
references with items stored in an OCI layout.

Fixes sylabs#83
Fixes sylabs#81
dtrudg added a commit to dtrudg/oci-tools that referenced this issue Sep 27, 2024
@dtrudg
feat: AppendImage/Index with optional name.Reference
09e8b82 
Adds `f.AppendImage` and `f.AppendIndex`, which append a `v1.Image` or a
`v1.ImageIndex` to the SIF, respectively.

The `OptAppendReference` functional option can be used to provide a
`name.Reference` that will be stored as an annotation against the new
descriptor in the RootIndex, with the key
`org.opencontainers.image.ref.name`, as is convention for associating
references with items stored in an OCI layout.

Fixes sylabs#83
Fixes sylabs#81
@dtrudg dtrudg closed this as completed in #87 Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dtrudg dtrudg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: AppendImage/Index with optional name.Reference dtrudg/oci-tools
1 participant
@dtrudg