Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[layouts] update switch worskpace key bindings #13665

Conversation

practicalli-johnny
Copy link
Contributor

@practicalli-johnny practicalli-johnny commented Jun 10, 2020

Emacs 27.1 has tab bar functionality built in and over-rides the existing
keybindings for eyebrowse-next-window-config and
eyebrowse-previous-window-config

Change keybindings to g> and g> so they are no longer over-ridden.

Sorry, had to correct an error in the docs, pushed an updated commit.

Emacs 27.1 has tab bar functionality built in and over-rides the existing
keybindings for eyebrowse-next-window-config and
eyebrowse-previous-window-config

Change keybindings to `g>` and `g>` so they are no longer over-ridden.
@practicalli-johnny practicalli-johnny force-pushed the workspace-switch-keybinding-emacs27 branch from c6404cd to e086ef3 Compare June 10, 2020 12:41
@smile13241324
Copy link
Collaborator

Hmmm @jr0cket do we really have to change the bindings for emacs 27? I would have thought that we would be to able to overwrite them again, I find g< and g> pretty difficult to type at least on a German keyboard.

@practicalli-johnny
Copy link
Contributor Author

Open to other suggestions as I appreciate changing key bindings is not the smoothest option.

I could not figure out where the new code was for the tab bar key bindings. There didn't seem to be anything in the emacs.d directory.

Would putting the original eyebrowse keybindings in evil normal mode map, rather than evil motion mode map work?

Not particularly confident about the differences between the evil maps, except that switching to a motion mode will show the eyebrowse key bindings again.

Also couldn't find a way to switch explicitly to motion state without calling SPC SPC evil-motion-mode.

@practicalli-johnny
Copy link
Contributor Author

practicalli-johnny commented Jun 15, 2020

With hindsight I am closing this PR, as I dont really like changing keybindings if I can help it.

I raise issue, #13677, to see if there is a better approach to managing workspaces now that tabs have been introduced into Emacs by default from Emacs 27 onward.

I will add a custom keybinding in dotspacemacs/user-config to cycle workspaces for now.

@practicalli-johnny practicalli-johnny deleted the workspace-switch-keybinding-emacs27 branch June 15, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants