-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
can we have the choice of hledger or ledger as the basis for the finance layer? #16237
Comments
So, the key binding you made with that snippet is:
As for layers, I think there is probably not too much in common that hledger and ledger would have (at least in terms of the Emacs configuration side). Perhaps it should just be a separate hledger layer (and arguably |
Finance layer wraps ledger-mode. |
Why force users to choose between having ledger-mode and hledger-mode installed (by having a mutually exclusive (In particular, the file formats are not compatible---I have used ledger for a long time and was not able to use hledger out of the box, without significant modifications to my files that degraded the experience with ledger). |
It's not about forcing a choice, it's about giving choice and not excluding all of those who use hledger. A normal use case is that someone uses either one or the other, a migration between ledger and hledger shouldn't be in scope of the layer. Of course, it's easy to see what is actually installed on the user system and auto-configure the right backend. If both hledger and ledger are installed, then I agree that user would be forced to choice. Just to emphasize my point again, what I imagine is not switching back and forth between them, but just a possibility for the users who would like to use hledger to set a hledger backend as a default . |
like doesn't the mail layer let you choose between mutt and mu4e? or is it opinionated?
…________________________________
From: Kuba-Jasinski ***@***.***>
Sent: Sunday, January 28, 2024 2:32 PM
To: syl20bnr/spacemacs ***@***.***>
Cc: Payne, Brandon ***@***.***>; Author ***@***.***>
Subject: Re: [syl20bnr/spacemacs] can we have the choice of hledger or ledger as the basis for the finance layer? (Issue #16237)
It's not about forcing a choice, it's about giving choice and not excluding all of those who use hledger.
A normal use case is that someone uses either one or the other, a migration between ledger and hledger shouldn't be in scope of the layer.
Of course, it's easy to see what is actually installed on the user system and auto-configure the right backend. If both hledger and ledger are installed, then I agree that user would be forced to choice.
Just to emphasize my point again, what I imagine is not switching back and forth between them, but just a possibility for the users who would like to use hledger to set a hledger backend as a default .
—
Reply to this email directly, view it on GitHub<#16237 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/APXKAAAMQKHNXD7KPUDBEL3YQ2RWLAVCNFSM6AAAAABBNZF5SOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTGY4TQNZUGQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
There's no
My suggestion was not to exclude those who use hledger, but rather to create a separate hledger layer, in the same way that the different mail clients each have their own layer. I guess I just don't see the benefit in combining the ledger and hledger support in the same layer. There doesn't seem to be any configuration, key bindings, or even documentation to share between them. And if a user wants to switch between the two programs, they can always disable one layer and enable the other. |
Are there other packages in the Finance layer right now? Or just Ledger? I think if Finance is already a collection of packages, all carefully configured to work together, it wouldn't be so simple to mess around with. But if Finance currently just means Ledger, and if Ledger and Hledger both have enough users, I think having two different layers (with those names) probably makes more sense. |
Hledger support is now part of the finance layer. It looks like it plays well with ledger therefore I have just let it coexist no need for another config variable, users can use both systems if they like. One missing feature though is proper keybindings for the various hledger functions here I rely on real hledger users for suggestions or PRs. |
I have been trying to add a keybinding for the
hledger-balancesheet*
commandI used the template on the spacemacs man page.
(spacemacs/declare-prefix-for-mode 'hledger-mode "mo" "custom") (spacemacs/set-leader-keys-for-major-mode 'hledger-mode "os" 'hledger-balancesheet*)
of course I wanted SPC-b-s but that is the scratch buffer. Anyway to make a minor mode
keybinding override a universal keybinding? I think mule does. Sorry if this is the wrong place. Probably should have tried stack overflow. Is there a system for suggesting layers if we come up with a good personal layer? I guess a pull request? Love your work, I've probably been with you about 4 years.
The text was updated successfully, but these errors were encountered: