Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MSRV to 1.72 #625

Merged
merged 4 commits into from
Sep 10, 2023
Merged

Update MSRV to 1.72 #625

merged 4 commits into from
Sep 10, 2023

Conversation

lukechu10
Copy link
Member

Fixes broken CI

Also updates NodeJS version in CI to 18.x

@lukechu10 lukechu10 added BREAKING CHANGE Breaking changes introduced in this PR A-ci Area: Continuous Integration (CI) labels Sep 10, 2023
@codecov
Copy link

codecov bot commented Sep 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.03% 🎉

Comparison is base (6bb700b) 62.17% compared to head (da82410) 62.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #625      +/-   ##
==========================================
+ Coverage   62.17%   62.21%   +0.03%     
==========================================
  Files          54       54              
  Lines        9413     9408       -5     
==========================================
  Hits         5853     5853              
+ Misses       3560     3555       -5     
Files Changed Coverage Δ
packages/sycamore-core/src/generic_node.rs 79.31% <0.00%> (+2.21%) ⬆️
packages/tools/bench-diff/src/main.rs 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukechu10 lukechu10 enabled auto-merge (squash) September 10, 2023 21:07
@lukechu10 lukechu10 merged commit ddf95d8 into sycamore-rs:master Sep 10, 2023
11 of 12 checks passed
@lukechu10 lukechu10 deleted the update-msrv branch November 5, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ci Area: Continuous Integration (CI) BREAKING CHANGE Breaking changes introduced in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant