Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify reconcile_fragments #423

Merged
merged 1 commit into from
May 20, 2022
Merged

Simplify reconcile_fragments #423

merged 1 commit into from
May 20, 2022

Conversation

lukechu10
Copy link
Member

No description provided.

@lukechu10 lukechu10 added the performance Performance related label May 20, 2022
@github-actions
Copy link

github-actions bot commented May 20, 2022

Finished dev [unoptimized + debuginfo] target(s) in 0.05s
 Running `/home/runner/work/sycamore/sycamore/sycamore/target/debug/bench-diff ../../../../js-framework-benchmark/webdriver-ts/results.json`

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of sycamore-baseline (typically latest master)
  • update: performance of sycamore (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                           Performance Diff                           @@

##                          | wasm-bindgen | baseline |  update |  diff ##
##########################################################################
- 01_run1k                  |       131.39 |   162.24 |  167.32 |   +3.13%
  02_replace1k              |       142.22 |   174.14 |  174.42 |   +0.16%
+ 03_update10th1k_x16       |       421.92 |   440.53 |  415.97 |   -5.57%
  04_select1k               |        56.40 |    77.66 |   78.19 |   +0.68%
  05_swap1k                 |        91.09 |   102.34 |  100.13 |   -2.16%
+ 06_remove-one-1k          |        32.93 |    34.96 |   33.00 |   -5.61%
  07_create10k              |      1491.10 |  2124.59 | 2138.39 |   +0.65%
  08_create1k-after1k_x2    |       305.41 |   381.34 |  378.97 |   -0.62%
+ 09_clear1k_x8             |        95.69 |   135.23 |  126.99 |   -6.09%
  21_ready-memory           |         1.47 |     1.44 |    1.44 |   -0.00%
  22_run-memory             |         1.35 |     1.68 |    1.68 |   -0.02%
  23_update5-memory         |         1.35 |     1.64 |    1.65 |   +0.19%
- 24_run5-memory            |         1.68 |     1.85 |    1.96 |   +6.00%
  25_run-clear-memory       |         1.41 |     1.28 |    1.28 |   -0.29%
- 31_startup-ci             |      1906.90 |  1905.94 | 2032.92 |   +6.66%
+ 32_startup-bt             |        21.54 |    40.66 |   34.75 |  -14.54%
- 33_startup-mainthreadcost |       230.75 |   238.20 |  256.15 |   +7.54%
  34_startup-totalbytes     |       189.16 |   277.87 |  277.77 |   -0.04%

Workflow: 2360258068
Adding new commits will generate a new report

@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #423 (98c46ff) into master (977baf0) will decrease coverage by 0.00%.
The diff coverage is 23.52%.

@@            Coverage Diff             @@
##           master     #423      +/-   ##
==========================================
- Coverage   64.87%   64.87%   -0.01%     
==========================================
  Files          52       52              
  Lines        8259     8256       -3     
==========================================
- Hits         5358     5356       -2     
+ Misses       2901     2900       -1     
Impacted Files Coverage Δ
packages/sycamore-core/src/render.rs 58.95% <23.52%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 977baf0...98c46ff. Read the comment docs.

@lukechu10 lukechu10 added performance Performance related and removed performance Performance related labels May 20, 2022
@github-actions
Copy link

github-actions bot commented May 20, 2022

Finished dev [unoptimized + debuginfo] target(s) in 0.05s
 Running `/home/runner/work/sycamore/sycamore/sycamore/target/debug/bench-diff ../../../../js-framework-benchmark/webdriver-ts/results.json`

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of sycamore-baseline (typically latest master)
  • update: performance of sycamore (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                           Performance Diff                           @@

##                          | wasm-bindgen | baseline |  update |  diff ##
##########################################################################
+ 01_run1k                  |       142.86 |   186.42 |  180.04 |   -3.42%
+ 02_replace1k              |       150.14 |   193.70 |  187.42 |   -3.24%
+ 03_update10th1k_x16       |       339.03 |   397.61 |  361.40 |   -9.11%
- 04_select1k               |        30.71 |    50.65 |   63.38 |  +25.14%
  05_swap1k                 |        81.54 |    83.04 |   84.60 |   +1.88%
  06_remove-one-1k          |        30.23 |    31.74 |   30.98 |   -2.40%
+ 07_create10k              |      1732.86 |  2674.11 | 2570.10 |   -3.89%
+ 08_create1k-after1k_x2    |       341.00 |   457.19 |  429.75 |   -6.00%
+ 09_clear1k_x8             |        95.86 |   138.58 |  133.76 |   -3.48%
  21_ready-memory           |         1.52 |     1.44 |    1.44 |   -0.00%
  22_run-memory             |         1.35 |     1.68 |    1.68 |   -0.03%
  23_update5-memory         |         1.35 |     1.65 |    1.64 |   -0.19%
  24_run5-memory            |         1.49 |     1.85 |    1.85 |   -0.27%
  25_run-clear-memory       |         1.41 |     1.28 |    1.27 |   -0.09%
  31_startup-ci             |      1804.51 |  1980.49 | 2004.30 |   +1.20%
- 32_startup-bt             |        32.09 |    39.77 |   59.65 |  +49.99%
- 33_startup-mainthreadcost |       268.93 |   269.99 |  317.93 |  +17.76%
  34_startup-totalbytes     |       189.16 |   277.87 |  277.77 |   -0.04%

Workflow: 2360320414
Adding new commits will generate a new report

@github-actions
Copy link

github-actions bot commented May 20, 2022

Finished dev [unoptimized + debuginfo] target(s) in 0.05s
 Running `/home/runner/work/sycamore/sycamore/sycamore/target/debug/bench-diff ../../../../js-framework-benchmark/webdriver-ts/results.json`

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of sycamore-baseline (typically latest master)
  • update: performance of sycamore (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                           Performance Diff                           @@

##                          | wasm-bindgen | baseline |  update |  diff ##
##########################################################################
- 01_run1k                  |       161.24 |   187.61 |  198.15 |   +5.62%
  02_replace1k              |       155.05 |   188.83 |  194.36 |   +2.93%
+ 03_update10th1k_x16       |       419.54 |   357.82 |  331.64 |   -7.32%
- 04_select1k               |        37.71 |    52.78 |   54.77 |   +3.78%
  05_swap1k                 |        81.83 |    82.81 |   83.51 |   +0.85%
+ 06_remove-one-1k          |        31.05 |    32.78 |   31.27 |   -4.63%
  07_create10k              |      1775.89 |  2566.21 | 2561.78 |   -0.17%
- 08_create1k-after1k_x2    |       374.72 |   422.15 |  441.85 |   +4.67%
+ 09_clear1k_x8             |       104.56 |   130.77 |  126.42 |   -3.33%
  21_ready-memory           |         1.52 |     1.44 |    1.44 |   -0.00%
  22_run-memory             |         1.35 |     1.68 |    1.68 |   -0.15%
  23_update5-memory         |         1.35 |     1.64 |    1.65 |   +0.08%
+ 24_run5-memory            |         1.49 |     1.94 |    1.85 |   -4.68%
- 25_run-clear-memory       |         1.41 |     1.27 |    1.42 |  +11.13%
+ 31_startup-ci             |      1809.21 |  2033.65 | 1931.91 |   -5.00%
+ 32_startup-bt             |        27.10 |    47.34 |   45.29 |   -4.32%
+ 33_startup-mainthreadcost |       278.94 |   341.86 |  279.50 |  -18.24%
  34_startup-totalbytes     |       189.16 |   277.87 |  277.77 |   -0.04%

Workflow: 2360320846
Adding new commits will generate a new report

@lukechu10 lukechu10 merged commit 487877f into master May 20, 2022
@lukechu10 lukechu10 deleted the simplify-reconcile branch May 20, 2022 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant