Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete should not be boolean attribute #301

Merged
merged 1 commit into from
Nov 13, 2021
Merged

Conversation

lukechu10
Copy link
Member

Closes #291

@lukechu10 lukechu10 added the C-bug Category: bug, something isn't working label Nov 13, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #301 (7d45701) into master (8634331) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #301      +/-   ##
==========================================
- Coverage   75.00%   75.00%   -0.01%     
==========================================
  Files          33       33              
  Lines        4797     4796       -1     
==========================================
- Hits         3598     3597       -1     
  Misses       1199     1199              
Impacted Files Coverage Δ
packages/sycamore-macro/src/view/attributes.rs 92.72% <ø> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8634331...7d45701. Read the comment docs.

@lukechu10 lukechu10 merged commit df16d18 into master Nov 13, 2021
@lukechu10 lukechu10 deleted the autocomplete-attr branch November 13, 2021 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: bug, something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocomplete should not be a boolean attribute
2 participants