Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hydrate #240

Merged
merged 42 commits into from
Nov 26, 2021
Merged

Hydrate #240

merged 42 commits into from
Nov 26, 2021

Conversation

lukechu10
Copy link
Member

@lukechu10 lukechu10 commented Sep 12, 2021

Closes #47 and #81

@lukechu10 lukechu10 added C-enhancement Category: new feature or improvement to existing feature A-SSR Area: Server Side Rendering (SSR) and Static Site Generation (SSG) labels Sep 12, 2021
@lukechu10 lukechu10 linked an issue Sep 13, 2021 that may be closed by this pull request
3 tasks
@lukechu10 lukechu10 added this to the v0.7 milestone Oct 15, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2021

Codecov Report

Merging #240 (8b9af54) into master (63ec424) will decrease coverage by 2.21%.
The diff coverage is 43.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #240      +/-   ##
==========================================
- Coverage   74.95%   72.73%   -2.22%     
==========================================
  Files          33       38       +5     
  Lines        4799     5142     +343     
==========================================
+ Hits         3597     3740     +143     
- Misses       1202     1402     +200     
Impacted Files Coverage Δ
packages/sycamore/src/generic_node/dom_node.rs 0.00% <0.00%> (ø)
packages/sycamore/src/generic_node/hydrate_dom.rs 0.00% <0.00%> (ø)
packages/sycamore/src/lib.rs 100.00% <ø> (ø)
packages/sycamore/src/utils/hydrate/web.rs 0.00% <0.00%> (ø)
packages/sycamore/src/utils/mod.rs 0.00% <ø> (ø)
packages/sycamore/src/utils/hydrate/mod.rs 75.40% <75.40%> (ø)
packages/sycamore/src/component.rs 87.50% <87.50%> (ø)
packages/sycamore-macro/src/view/element.rs 96.36% <94.84%> (-0.84%) ⬇️
packages/sycamore-macro/src/component/mod.rs 73.86% <100.00%> (ø)
packages/sycamore-macro/src/view/attributes.rs 92.72% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63ec424...8b9af54. Read the comment docs.

@lukechu10 lukechu10 added the BREAKING CHANGE Breaking changes introduced in this PR label Nov 6, 2021
@lukechu10 lukechu10 marked this pull request as ready for review November 15, 2021 03:18
@lukechu10 lukechu10 marked this pull request as draft November 15, 2021 04:28
@lukechu10 lukechu10 marked this pull request as ready for review November 23, 2021 17:55
@lukechu10 lukechu10 enabled auto-merge (squash) November 26, 2021 17:28
@lukechu10 lukechu10 disabled auto-merge November 26, 2021 17:29
@lukechu10 lukechu10 enabled auto-merge (squash) November 26, 2021 17:29
@lukechu10 lukechu10 disabled auto-merge November 26, 2021 17:31
@lukechu10 lukechu10 merged commit d10e0d4 into master Nov 26, 2021
@lukechu10 lukechu10 deleted the hydrate branch November 26, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-SSR Area: Server Side Rendering (SSR) and Static Site Generation (SSG) BREAKING CHANGE Breaking changes introduced in this PR C-enhancement Category: new feature or improvement to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hydrate DOM on client side Support for static rendering
2 participants