Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several updates in code #236

Open
wants to merge 46 commits into
base: main
Choose a base branch
from
Open

Several updates in code #236

wants to merge 46 commits into from

Conversation

C3EQUALZz
Copy link

  • Rewrote a few tests using pytest. Removed code duplication in some tests.
  • Removed your gcd implementation and replaced it with math.gcd from the Python standard library for better performance.
  • Modified the tox configuration to include checks using mypy and flake8. However, I have commented out flake8 due to some errors. The proposed solution does not meet my requirements
  • Updated variable names to resolve pep8 warnings from the PyCharm linter.
  • Upgraded to stable dependencies.

Traceback if I run flake8 in terminal

Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "D:\Progrramming\PycharmProjects\python-rsa\.venv\Scripts\flake8.exe\__main__.py", line 7, in <module>
  File "D:\Progrramming\PycharmProjects\python-rsa\.venv\Lib\site-packages\flake8\main\cli.py", line 22, in main
    app.run(argv)
  File "D:\Progrramming\PycharmProjects\python-rsa\.venv\Lib\site-packages\flake8\main\application.py", line 363, in run
    self._run(argv)
  File "D:\Progrramming\PycharmProjects\python-rsa\.venv\Lib\site-packages\flake8\main\application.py", line 350, in _run
    self.initialize(argv)
  File "D:\Progrramming\PycharmProjects\python-rsa\.venv\Lib\site-packages\flake8\main\application.py", line 330, in initialize
    self.find_plugins(config_finder)
  File "D:\Progrramming\PycharmProjects\python-rsa\.venv\Lib\site-packages\flake8\main\application.py", line 153, in find_plugins
    self.check_plugins = plugin_manager.Checkers(local_plugins.extension)
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\Progrramming\PycharmProjects\python-rsa\.venv\Lib\site-packages\flake8\plugins\manager.py", line 356, in __init__
    self.manager = PluginManager(
                   ^^^^^^^^^^^^^^
  File "D:\Progrramming\PycharmProjects\python-rsa\.venv\Lib\site-packages\flake8\plugins\manager.py", line 238, in __init__
    self._load_entrypoint_plugins()
  File "D:\Progrramming\PycharmProjects\python-rsa\.venv\Lib\site-packages\flake8\plugins\manager.py", line 254, in _load_entrypoint_plugins
    eps = importlib_metadata.entry_points().get(self.namespace, ())
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'EntryPoints' object has no attribute 'get'

@C3EQUALZz C3EQUALZz closed this Jun 9, 2024
C3EQUALZz and others added 16 commits June 9, 2024 14:32
Bumps the github-actions group with 2 updates: [actions/checkout](https://github.com/actions/checkout) and [actions/setup-python](https://github.com/actions/setup-python).


Updates `actions/checkout` from 3 to 4
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

Updates `actions/setup-python` from 4 to 5
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v4...v5)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions
...

Signed-off-by: dependabot[bot] <[email protected]>
…-actions-f039b2dc45

Bump the github-actions group with 2 updates
@C3EQUALZz C3EQUALZz reopened this Jun 15, 2024
dependabot bot and others added 2 commits July 6, 2024 02:20
Bumps the pip group with 2 updates in the / directory: [certifi](https://github.com/certifi/python-certifi) and [urllib3](https://github.com/urllib3/urllib3).


Updates `certifi` from 2024.6.2 to 2024.7.4
- [Commits](certifi/python-certifi@2024.06.02...2024.07.04)

Updates `urllib3` from 2.2.1 to 2.2.2
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
- [Commits](urllib3/urllib3@2.2.1...2.2.2)

---
updated-dependencies:
- dependency-name: certifi
  dependency-type: indirect
  dependency-group: pip
- dependency-name: urllib3
  dependency-type: indirect
  dependency-group: pip
...

Signed-off-by: dependabot[bot] <[email protected]>
Bump the pip group across 1 directory with 2 updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant