-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use latest pip on travis and enable caching #100
Conversation
This PR seems to reveal some test failures and broken coverage report:
|
ping @sybrenstuvel (you should enable github feature 'request review' for prs). |
I could make you collaborator, so that you can do that yourself. Would you like that? |
sounds good, thx. |
Nice work! The I do agree that those versions should be updated at some point. |
@sybrenstuvel I will define the latest and greatest in setup.py then? |
No, define the minimum required versions in the |
@sybrenstuvel pinned the versions in setup.py |
I may not have been clear in my explanation. The versions should be mimimal versions, i.e. |
(version numbers there are for illustration only, they could very well be different) |
@sybrenstuvel gotcha, see update. |
Better, but why still delete In |
@sybrenstuvel restored the file and addressed your comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of good changes, thanks!
flickrapi/__version__.py