Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Support for Thanos >= v0.13.0 #25

Closed
malyem opened this issue Sep 16, 2020 · 2 comments
Closed

[FEATURE] Support for Thanos >= v0.13.0 #25

malyem opened this issue Sep 16, 2020 · 2 comments

Comments

@malyem
Copy link

malyem commented Sep 16, 2020

In Thanos version v0.13.0 invocation for thanos bucket web has been changed thanos-io/thanos#2513.
Valid execution should be thanos tools bucket web.
We have at least two options to fix it in Puppet:

  1. Add tools in https://github.com/syberalexis/puppet-thanos/blob/master/manifests/bucket_web.pp#L71
  2. Refactor all files and invocations to keep naming convention, for example manifests/bucket_web.pp should be manifests/bucket_tools_web.pp...
@syberalexis
Copy link
Owner

I have already start to support Thanos version 0.14.0.
I will do some changes to support version 0.15.0 and test it before pull it ;)

syberalexis added a commit that referenced this issue Sep 20, 2020
@syberalexis
#25 Support Thanos version 0.15.0
19a407a
@syberalexis syberalexis mentioned this issue Sep 20, 2020
Merged
syberalexis added a commit that referenced this issue Sep 20, 2020
@syberalexis
Support Thanos version 0.15.0 (#25)
163c815
syberalexis added a commit that referenced this issue Sep 21, 2020
@syberalexis
Support Thanos version 0.15.0 (#25)
e1523ff
syberalexis added a commit that referenced this issue Sep 21, 2020
@syberalexis
Support Thanos version 0.15.0 (#25)
d75b1f0
@syberalexis
Copy link
Owner

Fixed and deployed in version 1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@malyem @syberalexis