src: skip revoke_data_object if uuid is not found

Fix: nodejs#42206 PR-URL: nodejs#42212 Fixes: nodejs#42206 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
sxa · Mar 7, 2022 · 0abc20b · 0abc20b
1 parent 5b23e67
commit 0abc20b
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/doc/api/url.md b/doc/api/url.md
@@ -659,7 +659,8 @@ added: v16.7.0
 * `id` {string} A `'blob:nodedata:...` URL string returned by a prior call to
   `URL.createObjectURL()`.
 
-Removes the stored {Blob} identified by the given ID.
+Removes the stored {Blob} identified by the given ID. Attempting to revoke a
+ID that isn’t registered will silently fail.
 
 ### Class: `URLSearchParams`
 

diff --git a/src/node_blob.cc b/src/node_blob.cc
@@ -444,7 +444,9 @@ void BlobBindingData::store_data_object(
 }
 
 void BlobBindingData::revoke_data_object(const std::string& uuid) {
-  CHECK_NE(data_objects_.find(uuid), data_objects_.end());
+  if (data_objects_.find(uuid) == data_objects_.end()) {
+    return;
+  }
   data_objects_.erase(uuid);
   CHECK_EQ(data_objects_.find(uuid), data_objects_.end());
 }

diff --git a/test/parallel/test-blob-createobjecturl.js b/test/parallel/test-blob-createobjecturl.js
@@ -29,6 +29,10 @@ const assert = require('assert');
     Buffer.from(await otherBlob.arrayBuffer()).toString(),
     'hello');
   URL.revokeObjectURL(id);
+
+  // should do nothing
+  URL.revokeObjectURL(id);
+
   assert.strictEqual(resolveObjectURL(id), undefined);
 
   // Leaving a Blob registered should not cause an assert