Introduce CompletionTriggers
#829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replacing the previous list of `re.Patterns`, lanuage features now need to declare a `CompletionTrigger` which describes the conditions required before completions should be triggered. This allows features to declare, in addition to the patterns, the language and trigger characters they require.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing the previous list of
re.Patterns, language features now need to declare aCompletionTriggerwhich describes the conditions required before completions should be triggered.This allows features to declare, in addition to the patterns, the language and trigger characters they require. (Closes #413)
By limiting the existing features to the languages they support fixes #800
Lastly, the server will now include
eval-rstin its list of completion suggestions for MyST files (Closes #799)