Refactor directives #814
Merged
Refactor directives #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`python3` is probably the more portable option - and should guard against selecting python 2.x if that's still hanging around.
alcarney
force-pushed
the
refactor-directives
branch
from
acff90a to
90277c9
Compare
Rather than try and have a single `Directives` language feature that does all the work of discovering directives, suggesting completions AND making it all work for both rst and myst, this commit breaks the work up between multiple `LanguageFeatures`. There is a backend `Directives` feature, that will provide an API that the various frontend features can use. Then there is the `RstDirectives` and `MystDirectives` features that build on the backend to surface the relevant features for their respective syntax. At the moment they are nearly identical however, they are now free to diverge to better support their associated syntax.
alcarney
force-pushed
the
refactor-directives
branch
from
90277c9 to
49f1b1d
Compare
Hopefully, this can sidestep any issues with not having pip available in the user's default Python installation
alcarney
force-pushed
the
refactor-directives
branch
from
49f1b1d to
5f5aef6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than try and have a single
Directiveslanguage feature that does all the work of discovering directives, suggesting completions AND making it all work for both rst and myst, this commit breaks the work up between multipleLanguageFeatures.There is a backend
Directivesfeature, that will provide an API that the various frontend features can use.Then there is the
RstDirectivesandMystDirectivesfeatures that build on the backend to surface the relevant features for their respective syntax. At the moment they are nearly identical however, they are now free to diverge to better support their associated syntaxThis PR also makes some improvements to the
Makefilestestsubcommand rather than usingtox