Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement language status items #756

Merged
merged 8 commits into from
Mar 14, 2024
Merged

Reimplement language status items #756

merged 8 commits into from
Mar 14, 2024

Conversation

alcarney
Copy link
Member

@alcarney alcarney commented Mar 14, 2024 •
edited
Loading

Screenshot_20240314_194757
Screenshot_20240314_195658

  • Instead of having a separate status item showing confdir, builddir etc, there is now a single sphinx related status item showing the version and the current active build command.
  • There is now also a Python status item showing the current active interpreter - with the option to change it.
  • The sphinx related status item will indicate when the sphinx process has crashed.

This is unlikely to be perfect, but hopefully it's a step towards resolving #736

alcarney added 7 commits March 14, 2024 19:47
@alcarney
code: Add esbonio.server.documentSelector option
9fde852
@alcarney
lsp: Fix traceback formatting
68fbce1
@alcarney
lsp: Have the sphinx client, rather than the agent pick the id
5121119
@alcarney
lsp: Send additional sphinx lifecycle notifications
f306327 
In addition to the `sphinx/appCreated` notification, the server will
now send, `sphinx/clientCreated`, `sphinx/clientErrored` and
`sphinx/clientDestroyed` notifications.
@alcarney
code: Reimplement language status items
c08d2a9 
We now have just two status items

- One for showing the current `pythonCommand` for the project.
  It also allows the user to trigger the `Python: Select Interpreter`
  command.

- One for showing the current (sphinx) `buildCommand`, the item also
  updates according to the current state of the client.
@alcarney
docs: Update main page
ea4a2c4
@alcarney
docs: Placeholder documentation for custom sphinx notifications
2611e64
@alcarney
lsp: Limit importlib-resources version
045b473 
There seems to be an issue with the latest releases
@alcarney alcarney merged commit 96fa4ed into swyddfa:develop Mar 14, 2024
13 of 14 checks passed
@alcarney alcarney deleted the language-status branch March 14, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alcarney