Re-implement completion for directives #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcarney
commented
Jan 1, 2024
This makes it easy for the parent language server to inspect the values
This allows the user to tell the server how they would prefer completions to behave. Also since this is implemented using the new config subscription framework, the user can change the setting on the fly!
Run `python -i scripts/sphinx-app.py` to easily get an Esbonio enabled Sphinx application object to inspect
Not only does this simplify the pattern, but this also removes a "Sphinx-ism" from something that should apply at the docutils/rst spec level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-implements completion suggestions for directives (as in
.. figure::or```{toctree}), completions for a directive's arguments and options will come in a future PR.Note: The MyST syntax for directives is a lot more complicated than the rst syntax, so the following is not yet supported
:::{note}style directivesinsertandreplacestyle of completions, using theesbonio.server.completion.preferredInsertBehavioroption as before.Thanks to the new configuration framework, you can even switch between them without restarting the server!
esboniowill finally respect the..default-domain::directive when generating completion suggestions! Closes Support the default-domain directive #105Related: #312