Report build errors to the client #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcarney
force-pushed
the
build-errors
branch
from
1c3b10f to
1fff66f
Compare
The server now catches and reports any errors encountered during sphinx application creation/builds to the client using `window/showMessage`. It is not my favourite solution since this could get very obnoxious if it takes a while to resolve the error, but I'm not sure what mechanism would work for all clients just yet.
This prevents us from effectively caching the error state and allowing the server to retry a failed application creation.
alcarney
force-pushed
the
build-errors
branch
from
1fff66f to
cd74394
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #662